Skip to content

Fix 'az webapp config ssl bind' for web apps in kubernetes environments #4129

Merged
panchagnula merged 5 commits intoAzure:mainfrom
StrawnSC:fix_ssl_bind_for_lima
Dec 2, 2021
Merged

Fix 'az webapp config ssl bind' for web apps in kubernetes environments #4129
panchagnula merged 5 commits intoAzure:mainfrom
StrawnSC:fix_ssl_bind_for_lima

Conversation

@StrawnSC
Copy link
Contributor

@StrawnSC StrawnSC commented Nov 18, 2021

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@StrawnSC StrawnSC marked this pull request as ready for review November 18, 2021 21:29
@yonzhan yonzhan added this to the Nov 2021 (2021-12-07) milestone Nov 18, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 18, 2021

webapp

@StrawnSC StrawnSC requested a review from panchagnula November 18, 2021 22:51
@StrawnSC StrawnSC marked this pull request as draft November 18, 2021 23:31
wangzelin007
wangzelin007 reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update setup.py to release the new extension version.
And may I ask you to add some scenario tests for those new commands?

@panchagnula
Copy link
Contributor

panchagnula commented Nov 30, 2021

@StrawnSC is this PR ready for review & if so can we get this released on the extension soon. Thanks!

@StrawnSC
Copy link
Contributor Author

StrawnSC commented Nov 30, 2021

@panchagnula sorry for the hold up -- I was taking some time to test and make sure that certificate binding was working for lima web apps and lima web app slots. I'm marking the PR ready for review

@wangzelin007 thanks, I just updated the setup.py. About scenario tests, as we mentioned here, the process of setting up an AKS cluster to put kubernetes environments in is quite lengthy/time-consuming and doesn't lend itself well to automated testing. So far, we've been manually testing the commands. We're planning on finding a way to add scenario tests before integrating this into the core CLI

@StrawnSC StrawnSC marked this pull request as ready for review November 30, 2021 18:13
panchagnula
panchagnula approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panchagnula panchagnula merged commit 192c045 into Azure:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangzelin007 wangzelin007 wangzelin007 approved these changes

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

+1 more reviewer

@panchagnula panchagnula panchagnula approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zhoxing-ms zhoxing-ms

Labels

None yet

Projects

None yet

Milestone

Nov 2021 (2021-12-07)

Development

Successfully merging this pull request may close these issues.

5 participants

@StrawnSC @yonzhan @panchagnula @wangzelin007 @zhoxing-ms